Allow MeshCoord to have a coord-system #6016
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() to respect that.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6016 +/- ##
==========================================
- Coverage 89.78% 89.76% -0.02%
==========================================
Files 90 90
Lines 22945 22991 +46
Branches 5026 5031 +5
==========================================
+ Hits 20602 20639 +37
- Misses 1612 1621 +9
Partials 731 731 ☔ View full report in Codecov by Sentry. |
pp-mo
changed the title
This was
linked to
issues
Jun 20, 2024
pp-mo
commented
Jun 23, 2024
| return None | ||
| """The coordinate-system of a MeshCoord comes from its origin coords.""" | ||
| select_kwargs = { | ||
| f"include_{self.location}s": True, |
There was a problem hiding this comment.
On second thoughts, by analogy with #4860 this should probably always use "include_nodes".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a MeshCoord have the coord-system of the appropriate location coordinate.
Note though that, as loaded from NetCDF-CF, location coords can't actually have a coord-system at present.
Because the load rules only call
build_auxiliary_coordinatein one place, and a coord-system (though supported) is never passed :In CF terms, this is because mesh coords are (at best) aux-coords of the data variable, and never dimension coords.
And a grid-mapping can currently only apply to dim-coords, because we don't yet support the extended grid-mapping syntax
However ... this does fix the copy error caused by a manually added coord-system