-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel concatenate #5926
Parallel concatenate #5926
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5926 +/- ##
==========================================
+ Coverage 89.78% 89.82% +0.03%
==========================================
Files 88 88
Lines 23060 23146 +86
Branches 5031 5043 +12
==========================================
+ Hits 20704 20790 +86
Misses 1624 1624
Partials 732 732 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: 11b4199Performance shifts
Full benchmark results
Generated by GHA run |
The benchmark report is a bit puzzling. I will look into it. Is there already a benchmark for |
iris/benchmarks/benchmarks/merge_concat.py Lines 42 to 61 in d9c4c1d
|
⏱️ Performance Benchmark Report: 060ea39Performance shifts
Full benchmark results
Generated by GHA run |
Thanks for the extensive review @trexfeathers! ✨ |
⏱️ Performance Benchmark Report: 758d9bePerformance shifts
Full benchmark results
Generated by GHA run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bouweandela I thoroughly approve of the changes you have made - nice job, and thanks very much for the comments/docstrings 💐
I have also decided - with some help - that the performance changes are a good trade-off 👍
- There is only 1 outstanding comment left from the first review: Parallel concatenate #5926 (comment)
I still haven't finished looking at the tests, but we're getting there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I think I'm done with the review now. You have done an epic job - it was hard enough to review this, I can't imagine how difficult it was to write it!
You might already be aware, but here is the final remaining action: #5926 (comment) |
Thanks, I was working on it 😉 Thanks a lot for the really extensive review! I think I have addressed all comments now. Should I run the benchmarks again? |
⏱️ Performance Benchmark Report: 6ee351fPerformance shifts
Full benchmark results
Generated by GHA run |
🚀 Pull Request
Description
Parallelize the comparison of the values of auxiliary coordinates, cell measures, ancillary variables, and derived coordinates during cube concatenation.
Closes #5750
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: