Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added in a vertical rule for surface fields #5734

Merged
merged 14 commits into from
Oct 28, 2024
Merged

Conversation

ESadek-MO
Copy link
Contributor

🚀 Pull Request

Closes #3820.

@ESadek-MO ESadek-MO requested a review from pp-mo February 7, 2024 09:57
@ESadek-MO ESadek-MO self-assigned this Feb 7, 2024
@pp-mo
Copy link
Member

pp-mo commented Feb 8, 2024

Note about the currently failing tests ...

These PP save tests are checked by comparing a string representation of all the resulting PP fields against one stored in a text file under iris/tests/results/cube_to_pp.
This is done with the "cube_save_test" method supplied here.

So, you should just delete all those files, and run all tests which will re-make them.
Then commit the resulting changes, which can then be reviewed.

NOTE: for no very good reason AFAICT, this check is implemented separately from the other compare-to-stored-file tests of this nature, and does NOT require IRIS_TEST_CREATE_MISSING=1 to be set (which was probably just an oversight IMHO).

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (8fe2b1f) to head (0b99c85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5734   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          88       88           
  Lines       23303    23306    +3     
  Branches     4335     4336    +1     
=======================================
+ Hits        20944    20947    +3     
  Misses       1628     1628           
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO ESadek-MO marked this pull request as ready for review September 6, 2024 13:11
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few docs improvements needed, I think

docs/src/whatsnew/latest.rst Outdated Show resolved Hide resolved
lib/iris/fileformats/pp.py Show resolved Hide resolved
lib/iris/fileformats/pp.py Show resolved Hide resolved
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple changes needed. I think it's worth being a little bit more specific in a few places.

docs/src/further_topics/um_files_loading.rst Outdated Show resolved Hide resolved
docs/src/further_topics/um_files_loading.rst Outdated Show resolved Hide resolved
lib/iris/fileformats/pp.py Outdated Show resolved Hide resolved
lib/iris/fileformats/pp.py Outdated Show resolved Hide resolved
@pp-mo
Copy link
Member

pp-mo commented Oct 28, 2024

From @stephenworsley offline : Says he is happy now, once I agree that my comments are addressed.
So Good To Go ™️ !

@pp-mo pp-mo enabled auto-merge (squash) October 28, 2024 11:33
@pp-mo pp-mo disabled auto-merge October 28, 2024 11:36
@pp-mo pp-mo merged commit 9c29117 into SciTools:main Oct 28, 2024
21 checks passed
HGWright added a commit to HGWright/iris that referenced this pull request Oct 31, 2024
* upstream/main: (194 commits)
  Restore latest Whats New files.
  [pre-commit.ci] pre-commit autoupdate (SciTools#6205)
  correct major minor in whatsnew (SciTools#6202)
  What's new updates for v3.11.0rc0 . (SciTools#6201)
  Update CF standard names table. (SciTools#6200)
  Specify meta in dask.array.map_blocks (SciTools#5989)
  added in a vertical rule for surface fields (SciTools#5734)
  Updated environment lockfiles (SciTools#6197)
  Reduce duplication in cf.py spanning checks. (SciTools#6196)
  Fix attribute array comparison (SciTools#6181)
  Enable factory references to create new dimensions on load. (SciTools#6168) (SciTools#6194)
  Improve handling of masks in concatenate (SciTools#6187)
  Demo Numpy v2 (SciTools#6035)
  Bump scitools/workflows from 2024.10.1 to 2024.10.2 (SciTools#6186)
  Document use of new_axis to control merge (SciTools#6180)
  Updated environment lockfiles (SciTools#6184)
  [pre-commit.ci] pre-commit autoupdate (SciTools#6175)
  Updated environment lockfiles (SciTools#6183)
  Update to `cell_method` parsing (SciTools#6083)
  Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect LBLEV in pp save rules for surface fields.
3 participants