-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added in a vertical rule for surface fields #5734
Conversation
Note about the currently failing tests ... These PP save tests are checked by comparing a string representation of all the resulting PP fields against one stored in a text file under iris/tests/results/cube_to_pp. So, you should just delete all those files, and run all tests which will re-make them. NOTE: for no very good reason AFAICT, this check is implemented separately from the other compare-to-stored-file tests of this nature, and does NOT require IRIS_TEST_CREATE_MISSING=1 to be set (which was probably just an oversight IMHO). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5734 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 88 88
Lines 23303 23306 +3
Branches 4335 4336 +1
=======================================
+ Hits 20944 20947 +3
Misses 1628 1628
Partials 731 731 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
a2b5383
to
8b0bbd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few docs improvements needed, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple changes needed. I think it's worth being a little bit more specific in a few places.
From @stephenworsley offline : Says he is happy now, once I agree that my comments are addressed. |
* upstream/main: (194 commits) Restore latest Whats New files. [pre-commit.ci] pre-commit autoupdate (SciTools#6205) correct major minor in whatsnew (SciTools#6202) What's new updates for v3.11.0rc0 . (SciTools#6201) Update CF standard names table. (SciTools#6200) Specify meta in dask.array.map_blocks (SciTools#5989) added in a vertical rule for surface fields (SciTools#5734) Updated environment lockfiles (SciTools#6197) Reduce duplication in cf.py spanning checks. (SciTools#6196) Fix attribute array comparison (SciTools#6181) Enable factory references to create new dimensions on load. (SciTools#6168) (SciTools#6194) Improve handling of masks in concatenate (SciTools#6187) Demo Numpy v2 (SciTools#6035) Bump scitools/workflows from 2024.10.1 to 2024.10.2 (SciTools#6186) Document use of new_axis to control merge (SciTools#6180) Updated environment lockfiles (SciTools#6184) [pre-commit.ci] pre-commit autoupdate (SciTools#6175) Updated environment lockfiles (SciTools#6183) Update to `cell_method` parsing (SciTools#6083) Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179) ...
🚀 Pull Request
Closes #3820.