-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff compliance for D401. #5687
Conversation
* upstream/main: ruff complliance for D100. (SciTools#5678)
for more information, see https://pre-commit.ci
* 'ruff_D205_2' of github.com:tkknight/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5687 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22809 22809
Branches 5440 5440
=======================================
Hits 20458 20458
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
* upstream/main: ruff compliance for D205. (SciTools#5681) Added whatsnew to warnings PR (SciTools#5696) Removed use of catch_warnings (SciTools#5685) Better documentation for Cube names in curl (SciTools#5680) fix typo (SciTools#5689) Make further topics obviously different (SciTools#5684) [pre-commit.ci] pre-commit autoupdate (SciTools#5682)
…D401_imperative_mood * 'D401_imperative_mood' of github.com:tkknight/iris:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkknight Awesome, thanks 🚀
Just a couple of minor comments to service, then we can bank this 👍
Co-authored-by: Bill Little <[email protected]>
* upstream/main: ruff compliance for D401. (SciTools#5687) Bump actions/cache from 3 to 4 (SciTools#5703)
* upstream/main: (26 commits) Bump scitools/workflows from 2023.12.1 to 2024.01.0 (SciTools#5710) Faster trivial equality checks for coordinates and arrays (SciTools#5691) Make the Coord.cell method lazy (SciTools#5693) Re-write `pearsonr` to use `Resolve` (SciTools#5638) ruff compliance for D401. (SciTools#5687) Bump actions/cache from 3 to 4 (SciTools#5703) update rtd ubuntu and mambaforge (SciTools#5702) [pre-commit.ci] pre-commit autoupdate (SciTools#5699) ruff compliance for D205. (SciTools#5681) Added whatsnew to warnings PR (SciTools#5696) Removed use of catch_warnings (SciTools#5685) Better documentation for Cube names in curl (SciTools#5680) fix typo (SciTools#5689) Make further topics obviously different (SciTools#5684) [pre-commit.ci] pre-commit autoupdate (SciTools#5682) ruff complliance for D100. (SciTools#5678) move tests.pp to tests.__init__ (SciTools#5679) ruff compliance for D417, D106 (SciTools#5677) ruff compliance for D200. (SciTools#5675) ruff compliance for D106. (SciTools#5676) ...
🚀 Pull Request
Description
PR solely for fixing
D401: First line of docstring should be in imperative mood: ...
Continues work of #5625.
Consult Iris pull request check list