Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff compliance for D106. #5676

Merged
merged 2 commits into from
Jan 3, 2024
Merged

ruff compliance for D106. #5676

merged 2 commits into from
Jan 3, 2024

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Jan 3, 2024

🚀 Pull Request

Description

PR solely for fixing D106: Missing docstring in public nested class

Continues work of #5625.


Consult Iris pull request check list

@tkknight tkknight mentioned this pull request Jan 3, 2024
13 tasks
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd41438) 89.69% compared to head (34ad437) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5676   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight marked this pull request as ready for review January 3, 2024 14:58
@tkknight tkknight requested a review from bjlittle January 3, 2024 14:58
@bjlittle bjlittle self-assigned this Jan 3, 2024
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Thanks again 💯

@bjlittle bjlittle merged commit cfa3644 into SciTools:main Jan 3, 2024
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Jan 3, 2024
* main:
  ruff compliance for D106. (SciTools#5676)
  ruff complliance for rule D202. (SciTools#5674)
  nep29 drop numpy 1.22 (SciTools#5668)
  ruff compliance for D404. (SciTools#5671)
  ruff complliance for D406. (SciTools#5670)
  ruff compliance for D405 and D407 (SciTools#5666)
  Various ruff rule compliance (W, CPY, ISC, AIR) (SciTools#5667)
tkknight added a commit to tkknight/iris that referenced this pull request Jan 4, 2024
* upstream/main:
  ruff compliance for D106. (SciTools#5676)
tkknight added a commit to tkknight/iris that referenced this pull request Jan 24, 2024
* upstream/main: (26 commits)
  Bump scitools/workflows from 2023.12.1 to 2024.01.0 (SciTools#5710)
  Faster trivial equality checks for coordinates and arrays (SciTools#5691)
  Make the Coord.cell method lazy (SciTools#5693)
  Re-write `pearsonr` to use `Resolve` (SciTools#5638)
  ruff compliance for D401. (SciTools#5687)
  Bump actions/cache from 3 to 4 (SciTools#5703)
  update rtd ubuntu and mambaforge (SciTools#5702)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5699)
  ruff compliance for D205. (SciTools#5681)
  Added whatsnew to warnings PR (SciTools#5696)
  Removed use of catch_warnings (SciTools#5685)
  Better documentation for Cube names in curl (SciTools#5680)
  fix typo (SciTools#5689)
  Make further topics obviously different (SciTools#5684)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5682)
  ruff complliance for D100. (SciTools#5678)
  move tests.pp to tests.__init__ (SciTools#5679)
  ruff compliance for D417, D106 (SciTools#5677)
  ruff compliance for D200. (SciTools#5675)
  ruff compliance for D106. (SciTools#5676)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants