add citation file and validating GHA #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5483 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
|
Not sure if this helps, but I just stumbled on some advice elsewhere, which seems to suggest it's really easy to automate this for each release. I'm not confident that I personally understand the issues here. But, might this be helpful ?? |
trexfeathers
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks for your patience, @HGWright! Here is your long-awaited review
…n-file * 'citation-file' of github.com:HGWright/iris: added - name: to CITATION.cff Merge commit
trexfeathers
requested changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This adds a CITATION.cff file and a GitHub Action to validate the CITATION.cff file.
I messed up the rebase somehow on #5161 and not the PR is very polluted, so I have remade the changes here and will capture the conversation that took place there at the bottom of this.
@bjlittle I have added you as the reviewer as you were also the reviewer for the previous PR.
I am also linking to #5453 and #4679 as they were mentioned in the original PR.
Closes #5118
The original PR comment:
Suggestion to add GHA:
Original review comments:
The comments that lead to the current approach: