-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some type annotations for coords.py
#4294
base: main
Are you sure you want to change the base?
Conversation
484a02b
to
9a87565
Compare
Rebased. CI is green. Ready for review 😎 |
9a87565
to
13a5a12
Compare
Added some type hints for the method and function I modified, as well as ones required to tidy up PyRight complaints within the |
now redundant as we turned hints off in the docs at #4510 |
13a5a12
to
29e312f
Compare
0361de4
to
af84640
Compare
af84640
to
a8186c7
Compare
@bjlittle get your finger out... |
@rcomer Fancy doing a rebase? |
a8186c7
to
668251d
Compare
Now rebased. @bjlittle it's all on you now 😛 |
668251d
to
8820c40
Compare
8820c40
to
1eebe2a
Compare
1eebe2a
to
4a3c441
Compare
cb44650
to
dd13194
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4294 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 88 88
Lines 23060 23064 +4
Branches 5031 5031
=======================================
+ Hits 20704 20708 +4
Misses 1624 1624
Partials 732 732 ☔ View full report in Codecov by Sentry. |
See #5955 for a version of this fix without the type-hinting rabbit hole. |
dd13194
to
d6e7f1b
Compare
for more information, see https://pre-commit.ci
coords.py
The bugfix has now been merged in #5955 so I have rebased this to only include the type changes. It seems that mypy is unhappy though and I'm not sure if/when I will be motivated to investigate that. |
🚀 Pull Request
Description
Added some type hints relevant to the changes in #5955
Consult Iris pull request check list