Introduce a new inventory JSON/dict format that preserves more primitive types #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jeandet
force-pushed
the
new_inventory_version
branch
from
5eab456 to
22a8120
Compare
It doesn't convert anymore to string primitive types or collections. Signed-off-by: Alexis Jeandet <[email protected]>
jeandet
force-pushed
the
new_inventory_version
branch
from
22a8120 to
11f8522
Compare
|
brenard-irap
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve inventory management and proxy version handling, as well as the addition of new tests. The most important changes include the introduction of versioning in
to_dictandfrom_dictfunctions, updates to the proxy version, and the addition of utility functions to handle primitive types.Inventory Management Enhancements:
speasy/core/inventory/indexes.py: Added aversionparameter to theto_dict,from_dict,to_json, andfrom_jsonfunctions to support different versions of inventory serialization. [1] [2]speasy/data_providers/cda/_inventory_builder/__init__.py: Updated various functions to use constants for inventory keys and added versioning support into_dictandfrom_dictcalls. [1] [2]speasy/data_providers/csa/__init__.py: Added the_only_primitive_typesfunction to ensure metadata contains only primitive types before serialization. [1] [2]Proxy Version Update:
speasy/core/proxy/__init__.py: Updated theMINIMUM_REQUIRED_PROXY_VERSIONto "0.12.0" and added versioning support in thegetfunction. [1] [2]Testing Enhancements:
tests/test_inventories.py: Added new tests to ensure that thefrom_dictandto_dictfunctions preserve the inventory structure and data accurately.