Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added the code for
LanceDB
vector store class.supports:
TODO : Code cleanup/minor fixes pending along with final schema. Add docs wherever necessary.
Testing :
I tested via adding an example, added
configs/local_ollama_lancedb.json
and tested viarun_test_client.py
.facing an issue in bulk insert have commented the code in
r2r/main/app.py
which I think is causing the issue, storage happens inembedding.py
via upsert_entries, but it is being called sequentially so bulk insert isnt happening, and therun()
method doesnt accept list() it accepts a singleDocumentPage
class.If I am doing something wrong here please let me know, otherwise would need to request some changes in the r2r code.
Thanks
Summary:
Integrates
LanceDB
as a new vector database provider, enhancing the system's capabilities with metadata filtering and addressing bulk insert issues.Key points:
LanceDB
integration for vector storage and retrieval.LanceDB
.Generated with ❤️ by ellipsis.dev