Update small_grants.md: Add 2 new benchmark sets and Param completion #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR certifies the completion of the two bnechmark sets by @ParamThakkar123 with the following PRs: * SciML/SciMLBenchmarks.jl#1148 * SciML/SciMLBenchmarks.jl#1160 * SciML/SciMLBenchmarks.jl#1159 It also adds two new benchmark sets that are in dire need of updates. As a monetary decision, requires 3 approvals. I approve.
ChrisRackauckas
requested review from
devmotion,
isaacsas,
TorkelE and
Vaibhavdixit02
Vaibhavdixit02
approved these changes
May 6, 2025
|
@ChrisRackauckas Should I go ahead and complete the new added benchmarks as well ? |
devmotion
approved these changes
May 6, 2025
|
Claim the benchmarks in a separate PR if you want. However, if you're still doing the Pumas internship, please do not double dip. |
Yeah. I am still doing the Pumas internship. I just wanted to contribute to a project in my free time so thought of this. But I am okay with your suggestion and will readily accept that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR certifies the completion of the two bnechmark sets by @ParamThakkar123 with the following PRs:
It also adds two new benchmark sets that are in dire need of updates.
As a monetary decision, requires 3 approvals. I approve.