Aqua CI #574
Open
Aqua CI #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
==========================================
- Coverage 30.42% 5.20% -25.22%
==========================================
Files 53 53
Lines 4030 3994 -36
==========================================
- Hits 1226 208 -1018
- Misses 2804 3786 +982 ☔ View full report in Codecov by Sentry. |
| @time @safetestset "Solution Indexing" begin | ||
| include("downstream/solution_interface.jl") | ||
| end | ||
| @time @safetestset "Symbol and integer based indexing of integrators" begin |
There was a problem hiding this comment.
Someone needs to find the time to change all of these to
@time @safetestset "Symbol and integer based indexing of integrators" include("downstream/integrator_indexing.jl")This is what we agreed on as the right way, and the formatter is fine with it, but we just never got around to it. These kinds of clean up PRs would be a good time to just throw the regex on it.
|
Those operators were deprecated and their documentation was deleted long ago. I think it's time to just remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how DiffEqScalar works, since the reported method ambiguity seems like it should be regularly called.
For the type piracy, this can be solved by giving L a type.
If the type is
AbstractDiffEqOperatorthen the method can stay here, but if it isAbstractSciMLOperatorthen the method should move.https://github.com/SciML/SciMLBase.jl/actions/runs/7359078663/job/20033302904?pr=574#step:6:728
https://github.com/SciML/SciMLBase.jl/actions/runs/7359078663/job/20033302904?pr=574#step:6:747