Fix scene audio mesh may play sound even when hidden

README.md

@@ -68,7 +68,6 @@ Rock Raiders Web is an experiment aimed at recreating Rock Raiders PC game (1999
 
 ### Cosmetics
 
-- One can hear rockies snoring behind walls in Level17
 - Add rotation speed to entities and play turnLeft, turnRight animations
 - Advisor not shown in tutorials near icon panel
 - Surface object pointer in tutorials removes surface highlight color as in original

src/scene/SceneAudioMesh.ts

@@ -1,4 +1,4 @@
-import { PositionalAudio } from 'three'
+import { Object3D, PositionalAudio } from 'three'
 import { SaveGameManager } from '../resource/SaveGameManager'
 import { SoundManager } from '../audio/SoundManager'
 import { SceneMesh } from './SceneMesh'
@@ -10,7 +10,7 @@ export class SceneAudioMesh extends SceneMesh {
 
     update(elapsedMs: number) {
         const sfxVolume = SaveGameManager.getSfxVolume()
-        if (sfxVolume <= 0) return
+        if (sfxVolume <= 0 || !this.isVisible()) return
         const sfxName = this.userData.sfxNameAnimation || ''
         if (!sfxName || (this.lastSfxName === sfxName && this.audioNode?.isPlaying)) return
         this.lastSfxName = sfxName
@@ -31,6 +31,15 @@ export class SceneAudioMesh extends SceneMesh {
         SoundManager.playingAudio.add(this.audioNode)
     }
 
+    private isVisible(): boolean {
+        if (!this.visible) return false
+        let parent: Object3D = this.parent
+        while (parent?.visible) {
+            parent = parent.parent
+        }
+        return !!parent?.visible
+    }
+
     dispose() {
         SoundManager.stopAudio(this.audioNode)
         this.lastSfxName = ''