Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate BZ 2250732 #15049

Merged
merged 1 commit into from
May 15, 2024
Merged

Automate BZ 2250732 #15049

merged 1 commit into from
May 15, 2024

Conversation

lhellebr
Copy link
Contributor

No description provided.

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 13, 2024
@lhellebr lhellebr requested a review from a team as a code owner May 13, 2024 16:23
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_nonsense_concurrency_level

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6906
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_nonsense_concurrency_level --external-logging
Test Result : ================= 5 passed, 365 warnings in 2391.93s (0:39:51) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024
@lhellebr lhellebr requested a review from a team May 13, 2024 17:38
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_nonsense_concurrency_level

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6909
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_nonsense_concurrency_level --external-logging
Test Result : ================= 5 passed, 349 warnings in 2274.00s (0:37:53) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_nonsense_concurrency_level

@lhellebr lhellebr requested a review from shweta83 May 14, 2024 08:26
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 14, 2024
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_nonsense_concurrency_level

rplevka
rplevka requested changes May 15, 2024
View reviewed changes
tests/foreman/cli/test_ansible.py Outdated
@@ -334,6 +335,35 @@ def test_positive_run_concurrent_jobs(self, rex_contenthosts, target_sat):
target_sat.cli.GlobalParameter().delete({'name': param_name})
assert len(target_sat.cli.GlobalParameter().list({'search': param_name})) == 0

@pytest.mark.parametrize('value', [0, -2, 2.5, 'a', '2.5'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding ids with some sane names to each value?
i'd rather have test called test_negative_invalid_concurrency_level_string and test_negative_invalid_concurrency_level_float than test_negative_invalid_concurrency_level_a and test_negative_invalid_concurrency_level_2.5

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_invalid_concurrency_level

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6938
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_invalid_concurrency_level --external-logging
Test Result : ============ 4 passed, 263 warnings, 1 error in 1944.21s (0:32:24) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 15, 2024
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_invalid_concurrency_level

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6939
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_negative_invalid_concurrency_level --external-logging
Test Result : ================= 4 passed, 266 warnings in 1937.38s (0:32:17) =================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 15, 2024
@rplevka rplevka merged commit bc57170 into SatelliteQE:master May 15, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request May 15, 2024
@lhellebr @web-flow
Automate BZ 2250732 (#15049)
b0636da 
(cherry picked from commit bc57170)
@Satellite-QE Satellite-QE mentioned this pull request May 15, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request May 16, 2024
@Satellite-QE @lhellebr
[6.15.z] Automate BZ 2250732 (#15071)
faac54a 
Automate BZ 2250732 (#15049)

(cherry picked from commit bc57170)

Co-authored-by: Lukáš Hellebrandt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rplevka rplevka rplevka approved these changes

@shweta83 shweta83 shweta83 approved these changes

Assignees

@lhellebr lhellebr

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lhellebr @Satellite-QE @rplevka @shweta83