Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for BZ:1931489 #15035

Merged
merged 1 commit into from
May 16, 2024
Merged

Add test coverage for BZ:1931489 #15035

merged 1 commit into from
May 16, 2024

Conversation

Gauravtalreja1
Copy link
Contributor

Problem Statement

Missing coverage for BZ:1931489, where we verified timeout to kill/execution_timeout_interval setting is honored by long running ansible-playbook job

Solution

Add test coverage for BZ:1931489, to verify long running ansible-playbook job along with timeout to kill/execution_timeout_interval setting

Dependent PRs:

SatelliteQE/nailgun#1139

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 10, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this May 10, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner May 10, 2024 17:45
@Gauravtalreja1
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py::TestAnsibleREX::test_negative_ansible_job_timeout_to_kill
nailgun: 1139

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6895
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_ansible.py::TestAnsibleREX::test_negative_ansible_job_timeout_to_kill --external-logging
Test Result : ================= 1 failed, 13 warnings in 1307.98s (0:21:47) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 10, 2024
@Gauravtalreja1
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py::TestAnsibleREX::test_negative_ansible_job_timeout_to_kill
nailgun: 1139

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6897
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_ansible.py::TestAnsibleREX::test_negative_ansible_job_timeout_to_kill --external-logging
Test Result : ================= 1 passed, 13 warnings in 1233.29s (0:20:33) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 10, 2024
Griffin-Sullivan
Griffin-Sullivan approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Acked the nailgun PR too.

shweta83
shweta83 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, pending one non-blocker comment.

@Gauravtalreja1
Add test coverage for BZ:1931489
4a67f39 
Signed-off-by: Gaurav Talreja <[email protected]>
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
@Gauravtalreja1
Copy link
Contributor Author

Just resolved the merge conflict, PRT passed in previous comment with build: 6897

@Gauravtalreja1 Gauravtalreja1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
@Gauravtalreja1 Gauravtalreja1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
@shubhamsg199 shubhamsg199 merged commit 1de4210 into SatelliteQE:master May 16, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:1931489 (#15035)
da953fa 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 1de4210)
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:1931489 (#15035)
798053c 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 1de4210)
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:1931489 (#15035)
1b937ab 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 1de4210)
This was referenced May 16, 2024
Open
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-timeout-kill branch May 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gauravtalreja1 @Satellite-QE @shweta83 @Griffin-Sullivan @shubhamsg199