-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement header param injection handling for JWT vulnerabilities #473
base: master
Are you sure you want to change the base?
Changes from all commits
0c23ff9
4812d61
262afac
ebcae74
be4751a
b7cea19
672b4ea
324fa33
261ea39
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,11 @@ | |
|
||
import static org.sasanlabs.service.vulnerability.jwt.bean.JWTUtils.GENERIC_BASE64_ENCODED_PAYLOAD; | ||
|
||
import com.nimbusds.jose.JWSVerifier; | ||
import com.nimbusds.jose.crypto.RSASSAVerifier; | ||
import com.nimbusds.jose.jwk.JWK; | ||
import com.nimbusds.jose.jwk.RSAKey; | ||
import com.nimbusds.jwt.SignedJWT; | ||
import java.io.UnsupportedEncodingException; | ||
import java.security.KeyPair; | ||
import java.security.interfaces.RSAPrivateKey; | ||
|
@@ -11,6 +16,7 @@ | |
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Optional; | ||
import javax.servlet.http.HttpServletRequest; | ||
import org.apache.logging.log4j.LogManager; | ||
import org.apache.logging.log4j.Logger; | ||
import org.sasanlabs.internal.utility.LevelConstants; | ||
|
@@ -662,4 +668,50 @@ private ResponseEntity<GenericVulnerabilityResponseBean<String>> getJWTResponseB | |
true, token, true, CollectionUtils.toMultiValueMap(headers)); | ||
return responseEntity; | ||
} | ||
|
||
@AttackVector( | ||
vulnerabilityExposed = VulnerabilityType.HEADER_INJECTION, | ||
description = "HEADER_INJECTION_VULNERABILITY") | ||
@VulnerableAppRequestMapping( | ||
value = LevelConstants.LEVEL_13, | ||
htmlTemplate = "LEVEL_13/HeaderInjection_Level13") | ||
public ResponseEntity<GenericVulnerabilityResponseBean<String>> getHeaderInjectionVulnerability( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry but there is a Level9 which has JWK based vulnerability. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @leiberbertel it is fine to have another vulnerability with same functionality as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand, thanks for the confirmation:). |
||
HttpServletRequest request) { | ||
String jwtToken = request.getHeader("Authorization"); | ||
if (jwtToken == null || !jwtToken.startsWith(JWTUtils.BEARER_PREFIX)) { | ||
return new ResponseEntity<>( | ||
new GenericVulnerabilityResponseBean<>("No JWT token provided", true), | ||
HttpStatus.BAD_REQUEST); | ||
} | ||
|
||
jwtToken = jwtToken.replaceFirst("^" + JWTUtils.BEARER_PREFIX, "").trim(); | ||
|
||
try { | ||
SignedJWT signedJWT = SignedJWT.parse(jwtToken); | ||
|
||
String jwkHeader = (String) signedJWT.getHeader().toJSONObject().get("jwk"); | ||
|
||
if (jwkHeader != null) { | ||
JWK jwk = JWK.parse(jwkHeader); | ||
RSAKey rsaKey = (RSAKey) jwk; | ||
RSAPublicKey publicKey = rsaKey.toRSAPublicKey(); | ||
|
||
JWSVerifier verifier = new RSASSAVerifier(publicKey); | ||
if (signedJWT.verify(verifier)) { | ||
return new ResponseEntity<>( | ||
new GenericVulnerabilityResponseBean<>( | ||
"JWK Header Injection Exploited!", false), | ||
HttpStatus.OK); | ||
} | ||
} | ||
|
||
} catch (Exception e) { | ||
return new ResponseEntity<>( | ||
new GenericVulnerabilityResponseBean<>("Invalid JWT", true), | ||
HttpStatus.BAD_REQUEST); | ||
} | ||
|
||
return new ResponseEntity<>( | ||
new GenericVulnerabilityResponseBean<>("Safe header", true), HttpStatus.OK); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
#header_injection_level_13 { | ||
color: black; | ||
text-align: justify; | ||
} | ||
|
||
#enterHeader { | ||
font-size: 15px; | ||
display: flex; | ||
margin: 10px; | ||
flex-direction: column; | ||
} | ||
|
||
#headerName, #headerValue { | ||
flex: 1; | ||
word-wrap: break-word; | ||
margin-top: 10px; | ||
} | ||
|
||
#headerResponse { | ||
font-size: 15px; | ||
word-wrap: break-word; | ||
text-align: center; | ||
margin: 10px; | ||
} | ||
|
||
#sendHeader { | ||
background: blueviolet; | ||
display: inline-block; | ||
padding: 4px 4px; | ||
margin: 10px; | ||
border: 1px solid transparent; | ||
border-radius: 2px; | ||
transition: 0.2s opacity; | ||
color: #FFF; | ||
font-size: 12px; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<title>Header Injection</title> | ||
</head> | ||
<body> | ||
<div id="header_injection_level_13"> | ||
<div> | ||
<div id="enterHeader"> | ||
<div>Header Name:</div> | ||
<input type="text" id="headerName" placeholder="Enter header name" /> | ||
<div>Header Value:</div> | ||
<input type="text" id="headerValue" placeholder="Enter header value" /> | ||
</div> | ||
<button id="sendHeader">Send Header</button> | ||
<div id="headerResponse"></div> | ||
</div> | ||
</div> | ||
|
||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
function addEventListenerToSendHeaderButton() { | ||
document.getElementById("sendHeader").addEventListener("click", function () { | ||
const headerName = document.getElementById("headerName").value; | ||
const headerValue = document.getElementById("headerValue").value; | ||
|
||
let url = getUrlForVulnerabilityLevel(); | ||
|
||
const manipulatedJwt = | ||
"eyJhbGciOiJSUzI1NiIsImtpZCI6Im1hbGljaW91cy1rZXktaWQifQ.eyJzdWIiOiJleGFtcGxldXNlciIsIm5hbWUiOiJKV1QgVXNlciIsImlhdCI6MTYwOTAxMjAwMH0.c7qHUq1HbHj8AWjKbcIYH2NZnE6PtNyXTnJTWZELvFbfbFhc5BQ_w8e24fXL2OzhhOT5qHVzFvHgOeEYFLZNGEDlJhF4o76yHsMJdWQFL4I5uZjG0o8XV0HjDdM7GqEmx2j0JHi6vJ8Q3pIqGzUBmb7bgzD4kENnP-UqfkbNl2ykYZ9Nybw_E7CAV4OxuqE4QyIpZV2VttWjefK3c6TIj9hNWvYYgipKwHFLXbOV-rOZ6K-_H_4D-kbr0LKPPX-s4b11o0wtS3y1FiHDXEvsmEjhRApEc_jk5uZY-AGPUc9Nl9t6iT_Nh1Q8Usz-jZifg03NwumJjDNtz-nS7gzg"; | ||
|
||
doGetAjaxCall( | ||
function (data) { | ||
document.getElementById("headerResponse").innerHTML = data.isValid | ||
? "Header Injection was successful!" | ||
: "Header Injection failed. Please try again."; | ||
}, | ||
url, | ||
true, | ||
{ | ||
[headerName]: headerValue, | ||
Authorization: `Bearer ${manipulatedJwt}`, | ||
} | ||
); | ||
}); | ||
} | ||
|
||
addEventListenerToSendHeaderButton(); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
#SampleVulnerability { | ||
color: black; | ||
text-align: center; | ||
} | ||
|
||
#fetchDetails { | ||
background: blueviolet; | ||
display: inline-block; | ||
padding: 8px 8px; | ||
margin: 10px; | ||
border: 2px solid transparent; | ||
border-radius: 3px; | ||
transition: 0.2s opacity; | ||
color: #FFF; | ||
font-size: 12px; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<div id="SampleVulnerability"> | ||
<div> | ||
<div id="level_info"> | ||
This is a Sample Vulnerability. please add the UI components here. | ||
</div> | ||
<button id=fetchDetails>Click Here</button> | ||
<div id="response"></div> | ||
</div> | ||
</div> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
function addingEventListenerToFetchData() { | ||
document | ||
.getElementById("fetchDetails") | ||
.addEventListener("click", function () { | ||
/** | ||
* getUrlForVulnerabilityLevel() method provides url to call the Vulnerability Level | ||
* of Sample Vulnerability. | ||
* e.g. /VulnerableApp/SampleVulnerability/LEVEL_1 for LEVEL_1 | ||
*/ | ||
let url = getUrlForVulnerabilityLevel(); | ||
/** | ||
* doGetAjaxCall() method is used to do the ajax get call to the Vulnerability Level | ||
*/ | ||
doGetAjaxCall(fetchDataCallback, url + "?name=dummyInput", true); | ||
}); | ||
} | ||
// Used to register event on the button or any other component | ||
addingEventListenerToFetchData(); | ||
|
||
//Callback function to handle the response and render in the UI | ||
function fetchDataCallback(data) { | ||
document.getElementById("response").innerHTML = data.content; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -235,7 +235,7 @@ function genericResponseHandler(xmlHttpRequest, callBack, isJson) { | |
} | ||
} | ||
|
||
function doGetAjaxCall(callBack, url, isJson) { | ||
function doGetAjaxCall(callBack, url, isJson, headers = {}) { | ||
let xmlHttpRequest = new XMLHttpRequest(); | ||
xmlHttpRequest.onreadystatechange = function () { | ||
genericResponseHandler(xmlHttpRequest, callBack, isJson); | ||
|
@@ -245,6 +245,11 @@ function doGetAjaxCall(callBack, url, isJson) { | |
"Content-Type", | ||
isJson ? "application/json" : "text/html" | ||
); | ||
|
||
for (const header in headers) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for this change. |
||
xmlHttpRequest.setRequestHeader(header, headers[header]); | ||
} | ||
|
||
xmlHttpRequest.send(); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please validate that it is backward compatible. Try to test other levels of JWT vulnerability,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have validated the other JWT vulnerabilities and they work correctly, ensuring that they stay within the expected parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !!! ❤️