Fix exporting async functions in ESM modules #1531
Merged
+21
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matetokodi
requested review from
bbrto21,
clover2123 and
ksh8281
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| this->consumeSemicolon(); | ||
| } else if (this->lookahead.type == Token::KeywordToken) { | ||
| } else if (this->lookahead.type == Token::KeywordToken || this->matchAsyncFunction()) { |
There was a problem hiding this comment.
The matchAsyncFunction() call appears twice: once in the outer condition and again inside the block. If matchAsyncFunction() consumes the 'async' keyword, the second call will see a different lookahead, causing the async function to be parsed incorrectly. Remove the outer call or store its result to avoid double consumption.
Add mjs file matching to regression test script
matetokodi
force-pushed
the
fix_esm_async_export
branch
from
0930cef to
3c6889a
Compare
ksh8281
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added regression test cases: Samsung/js_vendor_tc#97