Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Create ImageVisual synchronously if AlphaMaskURL use generated ImageUrl #6520

Open
wants to merge 1 commit into
base: DevelNUI
Choose a base branch
from

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Dec 17, 2024

Since ImageUrl's reference should be hold on image visual, we should generate image visual synchronously, not on Processor time.

Minor code clean up applied

Relative dali patch :
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/315535

@dongsug-song
Copy link
Contributor

@hinohie
Hello,
The TizenFX main branch has been changed for API13 (tizen_10).
So the DevelNUI branch also did a hard reset with the master branch to sync this.
I think you need to rebase this PR or re-upload the new PR.
I am sorry for the inconvenience.

@hinohie hinohie force-pushed the force_update_alphamask branch from 9f69845 to 3bc7a1d Compare December 18, 2024 03:49
…ImageUrl

Since ImageUrl's reference should be hold on image visual, we should generate
image visual synchronously, not on Processor time.

+

Minor code clean up applied

Signed-off-by: Eunki, Hong <[email protected]>
@hinohie hinohie force-pushed the force_update_alphamask branch from 3bc7a1d to b534c2e Compare December 18, 2024 04:07
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 1, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String Tizen.NUI.Visuals.ImageVisual::AlphaMaskUrl()

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.String Tizen.NUI.Visuals.ImageVisual::AlphaMaskURL()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants