[MachineLearning.Inference] Add MlInformation and MlInformationList #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public API ChangedPlease follow the ACR process for the changed API below. Added: 16, Removed: 0, Changed: 0Added+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformation::GetNumber(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.String Tizen.MachineLearning.Inference.MlInformation::GetString(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::.ctor()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetNumber(System.String,System.Int32)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetString(System.String,System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.TensorsData Tizen.MachineLearning.Inference.MlInformation::GetTensorsData(System.String)
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformationList
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformationList::GetLength()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation Tizen.MachineLearning.Inference.MlInformationList::GetInformation(System.Int32)
|
jaeyun-jung
reviewed
Dec 19, 2024
| /// Gets a int value of key in MlInformation instance. | ||
| /// </summary> | ||
| /// <param name="key">The key to be set.</param> | ||
| /// <returns>The string value of the key.</returns> |
There was a problem hiding this comment.
suggestion:
description: The integer value of the key.
method name: GetNumber/SetNumber -> GetInteger / SetInteger ?
There was a problem hiding this comment.
Updated description and method name :)
jaeyun-jung
reviewed
Dec 19, 2024
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets a int value of key in MlInformation instance. |
There was a problem hiding this comment.
Typo: Gets an int value
jaeyun-jung
reviewed
Dec 19, 2024
| /// <summary> | ||
| /// Gets a string value of key in MlInformation instance. | ||
| /// </summary> | ||
| /// <param name="key">The key to be set.</param> |
There was a problem hiding this comment.
231 and 248
The key to get the corresponding value.
jaeyun-jung
reviewed
Dec 19, 2024
| } | ||
|
|
||
| /// <summary> | ||
| /// Creates a MlInformation instance from Native handle. |
There was a problem hiding this comment.
Typo: from Native handle -> from native handle
jaeyun-jung
reviewed
Dec 19, 2024
| break; | ||
| case InfoType.Information: | ||
| ret = NNStreamerError.NotSupported; | ||
| Log.Error(NNStreamer.TAG, "InfoType Iniformation does not support set value"); |
There was a problem hiding this comment.
Typo: Iniformation -> Information
jaeyun-jung
reviewed
Dec 19, 2024
| break; | ||
| } | ||
|
|
||
| NNStreamer.CheckException(ret, "Failed to set string value"); |
There was a problem hiding this comment.
typo: set string value -> set integer value
niley7464
force-pushed
the
inference/information
branch
from
4bb38a7 to
644f08b
Compare
Public API ChangedPlease follow the ACR process for the changed API below. Added: 16, Removed: 0, Changed: 0Added+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformation::GetInteger(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.String Tizen.MachineLearning.Inference.MlInformation::GetString(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::.ctor()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetInteger(System.String,System.Int32)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetString(System.String,System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.TensorsData Tizen.MachineLearning.Inference.MlInformation::GetTensorsData(System.String)
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformationList
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformationList::GetLength()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation Tizen.MachineLearning.Inference.MlInformationList::GetInformation(System.Int32)
|
jaeyun-jung
reviewed
Dec 19, 2024
| NNStreamer.CheckException(ret, "Failed to set integer value"); | ||
| } | ||
|
|
||
| private IntPtr GetInformationHandle(string key) |
There was a problem hiding this comment.
Suggestion:
method name GetInformationHandle > GetValue
line 223, 240, 257, 276
error message "information handle from key" > "value of key from information handle"
There was a problem hiding this comment.
Changed method name and updated error message :)
There was a problem hiding this comment.
@again4you
After reviewing with Sangjung, let's start ACR :)
jaeyun-jung
reviewed
Dec 19, 2024
| /// <feature>http://tizen.org/feature/machine_learning.inference</feature> | ||
| /// <exception cref="ArgumentException">Thrown when the method failed due to an invalid parameter.</exception> | ||
| /// <since_tizen> 13 </since_tizen> | ||
| public string GetString(string key) |
There was a problem hiding this comment.
line 236, 253, 270 add exception 'not-supported' (GetInformationHandle() may raise an exception for this.)
/// <exception cref="NotSupportedException">Thrown when the feature is not supported.</exception>
There was a problem hiding this comment.
Added not-supported exception 👍
songgot
reviewed
Dec 19, 2024
| /// Releases any unmanaged resources used by this object. Can also dispose any other disposable objects. | ||
| /// </summary> | ||
| /// <param name="disposing">If true, disposes any disposable objects. If false, does not dispose disposable objects.</param> | ||
| protected virtual void Dispose(bool disposing) |
There was a problem hiding this comment.
Is /// <since_tizen> 13 </since_tizen> necessary?
niley7464
force-pushed
the
inference/information
branch
from
644f08b to
3266233
Compare
Public API ChangedPlease follow the ACR process for the changed API below. Added: 16, Removed: 0, Changed: 0Added+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformation::GetInteger(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.String Tizen.MachineLearning.Inference.MlInformation::GetString(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::.ctor()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetInteger(System.String,System.Int32)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetString(System.String,System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.TensorsData Tizen.MachineLearning.Inference.MlInformation::GetTensorsData(System.String)
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformationList
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformationList::GetLength()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation Tizen.MachineLearning.Inference.MlInformationList::GetInformation(System.Int32)
|
niley7464
force-pushed
the
inference/information
branch
from
3266233 to
6eee932
Compare
Public API ChangedPlease follow the ACR process for the changed API below. Added: 16, Removed: 0, Changed: 0Added+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformation::GetInteger(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.String Tizen.MachineLearning.Inference.MlInformation::GetString(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::.ctor()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetInteger(System.String,System.Int32)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetString(System.String,System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.TensorsData Tizen.MachineLearning.Inference.MlInformation::GetTensorsData(System.String)
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformationList
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformationList::GetLength()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation Tizen.MachineLearning.Inference.MlInformationList::GetInformation(System.Int32)
|
gichan-jang
reviewed
Dec 19, 2024
| /// </summary> | ||
| /// <param name="key">The key to be set.</param> | ||
| /// <param name="value">The value to be set.</param> | ||
| /// <feature>http://tizen.org/feature/machine_learning.inference</feature> |
There was a problem hiding this comment.
In the case of ml_inofrmation_*, it will be used in ml-service (and training?) later.
How about implementing these as a common part?
Tizen.MachineLearning or Tizen.MachineLearning.Common feature
There was a problem hiding this comment.
Tizen.MachineLearning.Inference must be included to use MlInformation.GetTensorsData.
So how about using Tizen.MachineLearning.Inference namespace like any other common part so that user don't have to declare multiple namespaces?
There was a problem hiding this comment.
Okay, let's use the Tizen.MachineLearning.Inference namespace now. Consider separating them to common parts when it becomes necessary later.
gichan-jang
reviewed
Dec 19, 2024
| /// Creates a MlInformationList instance. | ||
| /// </summary> | ||
| /// <feature>http://tizen.org/feature/machine_learning.inference</feature> | ||
| /// <exception cref="NotSupportedException">Thrown when the feature is not supported.</exception> |
There was a problem hiding this comment.
Please check the exception here and below.
I think in this case ArgumentException.
Suggested change
| /// <exception cref="NotSupportedException">Thrown when the feature is not supported.</exception> | |
| /// <exception cref="ArgumentException">Thrown when the method failed due to an invalid parameter.</exception> |
There was a problem hiding this comment.
Added ArgumentException
Thank you :)
This patch newly adds the MlInformation and MlInformationList class. These class manages information based on key-value. Added: - MlInformation - MlInformationList Signed-off-by: Yelin Jeong <[email protected]>
niley7464
force-pushed
the
inference/information
branch
from
6eee932 to
679f597
Compare
Public API ChangedPlease follow the ACR process for the changed API below. Added: 16, Removed: 0, Changed: 0Added+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformation::GetInteger(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.String Tizen.MachineLearning.Inference.MlInformation::GetString(System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::.ctor()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetInteger(System.String,System.Int32)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformation::SetString(System.String,System.String)
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.TensorsData Tizen.MachineLearning.Inference.MlInformation::GetTensorsData(System.String)
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformationList
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ System.Int32 Tizen.MachineLearning.Inference.MlInformationList::GetLength()
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Dispose(System.Boolean)
+ /// <since_tizen>13</since_tizen
+ System.Void Tizen.MachineLearning.Inference.MlInformationList::Finalize()
+ /// <privilege>http://tizen.org/feature/machine_learning.inference</privilege
+ /// <since_tizen>13</since_tizen
+ Tizen.MachineLearning.Inference.MlInformation Tizen.MachineLearning.Inference.MlInformationList::GetInformation(System.Int32)
|
jaeyun-jung
approved these changes
Dec 20, 2024
again4you
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch newly adds the MlInformation and MlInformationList class. These class manages information based on key-value.
Description of Change
Added:
API Changes