Skip to content

[onert] Implement BulkPipelineModel for Trix model execution #16332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
batcheu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[onert] Implement BulkPipelineModel for Trix model execution #16332

batcheu wants to merge 1 commit into from
+501 −0

Conversation

@batcheu
Copy link
Contributor

@batcheu batcheu commented Dec 3, 2025

This implements new BulkPipelineModel class to handle NPU model loading.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee [email protected]

@batcheu
Copy link
Contributor Author

batcheu commented Dec 3, 2025 

Note: Google Test filter = BulkPipelineModelTest.*
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from BulkPipelineModelTest
[ RUN      ] BulkPipelineModelTest.test_model_creation
[       OK ] BulkPipelineModelTest.test_model_creation (0 ms)
[ RUN      ] BulkPipelineModelTest.test_model_run
[       OK ] BulkPipelineModelTest.test_model_run (0 ms)
[ RUN      ] BulkPipelineModelTest.test_model_release
[       OK ] BulkPipelineModelTest.test_model_release (0 ms)
[----------] 3 tests from BulkPipelineModelTest (0 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 3 tests.

@batcheu batcheu marked this pull request as draft December 3, 2025 07:12
@batcheu
[onert] Implement BulkPipelineModel for Trix model execution
7650c0a 
This implements new BulkPipelineModel class to handle NPU model loading.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <[email protected]>
@batcheu batcheu force-pushed the introduce_bulkpipeline_model branch from c9f19d2 to 7650c0a Compare December 8, 2025 05:00
@batcheu batcheu marked this pull request as ready for review December 8, 2025 05:01
glistening
glistening reviewed Dec 9, 2025
View reviewed changes
runtime/onert/backend/trix/ops/BulkPipelineModel.h
Comment on lines +17 to +18
#ifndef __ONERT_BACKEND_TRIX_OPS_BULKPIPELINEMODEL_H__
#define __ONERT_BACKEND_TRIX_OPS_BULKPIPELINEMODEL_H__
Copy link
Contributor

@glistening glistening Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifndef __ONERT_BACKEND_TRIX_OPS_BULKPIPELINEMODEL_H__
#define __ONERT_BACKEND_TRIX_OPS_BULKPIPELINEMODEL_H__
#ifndef __ONERT_BACKEND_TRIX_OPS_BULK_PIPELINE_MODEL_H__
#define __ONERT_BACKEND_TRIX_OPS_BULK_PIPELINE_MODEL_H__

Could you please put a few _ between CamelStyle words?

Copy link
Contributor Author

@batcheu batcheu Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that I already did same typo errors in over previous commits ;(
Can I revise them all in other PR?

glistening
glistening reviewed Dec 9, 2025
View reviewed changes
runtime/onert/backend/trix/ops/BulkPipelineModel.h
} // namespace backend
} // namespace onert

#endif // __ONERT_BACKEND_TRIX_OPS_BULKPIPELINEMODEL_H__
Copy link
Contributor

@glistening glistening Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#endif // __ONERT_BACKEND_TRIX_OPS_BULKPIPELINEMODEL_H__
#endif // __ONERT_BACKEND_TRIX_OPS_BULK_PIPELINE_MODEL_H__

hseok-oh
hseok-oh approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llFreetimell
llFreetimell approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@llFreetimell llFreetimell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batcheu
Copy link
Contributor Author

batcheu commented Dec 30, 2025

@hseok-oh
Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glistening glistening glistening left review comments

@chunseoklee chunseoklee chunseoklee approved these changes

@hseok-oh hseok-oh hseok-oh approved these changes

@llFreetimell llFreetimell llFreetimell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@batcheu @chunseoklee @glistening @hseok-oh @llFreetimell