Skip to content

Conversation

@mbencer
Copy link
Contributor

@mbencer mbencer commented Apr 30, 2025

This commit extends onecc and one-build with one-resize.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]

Issue: #14791
Draft: #14727

This commit extends onecc and one-build with one-resize.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <[email protected]>
@mbencer mbencer requested a review from jinevening April 30, 2025 14:23
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As wrote in #15082 (comment) , I disagree on adding to one-cmds as of now.

@jinevening
Copy link
Collaborator

jinevening commented May 2, 2025

@mbencer Please do not upload changes in one-cmds. We've not made a decision to open one-resize to users as the same level with one-import/optimize/quantize.

FYI, I'm on leave until 5/21. Please ask @mhs4670go or @seanshpark if you need reviews. Since the cmdline tool (circle-resizer) is already merged, you can use that tool for your purpose in other projets (ex: TICO) after adding it to one-compiler pacakge.

@mbencer
Copy link
Contributor Author

mbencer commented May 2, 2025

As wrote in #15082 (comment) , I disagree on adding to one-cmds as of now.

@seanshpark Just for confirmation because I am not sure. Do you mean part:

We need more dicussion on how it will be integrated with onecc or python interfacce.

I didn't understand this as a decision to block the onecc integration. I've thought that there are some doubts which I wanted to clarify here.

Please also note that onecc integration was not my idea. In my initial version I exposed Python API to circle-resizer . I've followed the suggestion from #14791 (comment):

As I know you are to provide a new tool.
Our individual tools are integrated through one-cmds, onecc tool and also through sub tools,
if the feature is for users, to manipulate model files.
Please integrate it though this tool, and also prepare some UI tests like others,
though your draft PR, so that reviewers can provide some comments if something goes in different direction.

@mbencer
Copy link
Contributor Author

mbencer commented May 2, 2025

Please do not upload changes in one-cmds. We've not made a decision to open one-resize to users as the same level with one-import/optimize/quantize.

@jinevening Just for confirmation does it mean that users like TICO should call circle-resizer as a separate sub-process or should I wait for the final decision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants