Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTML file report generation for single scan #576

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Rework of the PR #573
The current PR contains the new HTML file reports generated (in a new format) for a single scan (scan of PR or local file(s)).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

java -jar -Dspring.profiles.active=singlescan target/lpvs-*.jar --github.pull.request=https://github.com/o-kopysov/LPVS/pull/2 --build.html.report=report.html
java -jar -Dspring.profiles.active=singlescan target/lpvs-*.jar --local.path=test --build.html.report=test/report.html

Report for the PR scan:
image

Report for the local folder scan:
image

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Aug 23, 2024
@o-kopysov o-kopysov added this to the v2.0.0 milestone Aug 23, 2024
@o-kopysov o-kopysov self-assigned this Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 97.28507% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.28%. Comparing base (8fce5a3) to head (0d32c56).

Files Patch % Lines
...java/com/lpvs/entity/report/LPVSReportBuilder.java 97.16% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #576      +/-   ##
============================================
+ Coverage     92.79%   93.28%   +0.49%     
- Complexity      547      579      +32     
============================================
  Files            48       49       +1     
  Lines          1818     1982     +164     
  Branches        222      232      +10     
============================================
+ Hits           1687     1849     +162     
  Misses           63       63              
- Partials         68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tdrozdovsky
tdrozdovsky previously approved these changes Aug 23, 2024
Comment on lines 74 to 75
private final String boldStart = "\033[1m";
private final String boldEnd = "\033[0m";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both this vars not used.

@o-kopysov o-kopysov requested a review from m-rudyk August 23, 2024 07:56
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@o-kopysov o-kopysov merged commit 1b69e16 into main Aug 23, 2024
10 checks passed
@o-kopysov o-kopysov deleted the html-report-update branch August 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants