Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Taking the LPVS version from the POM file #575

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR includes changes in how to get the LPVS application's current version.
The proposed approach doesn't need to add any dependency. It uses only application.properties and POM files of the project.
Because of changes in application start, unit tests were also modified and updated.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

By using unit tests and application start.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Aug 20, 2024
@o-kopysov o-kopysov added this to the v2.0.0 milestone Aug 20, 2024
@o-kopysov o-kopysov self-assigned this Aug 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (a7ab252) to head (d175616).

Files Patch % Lines
...ain/java/com/lpvs/LicensePreValidationService.java 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #575      +/-   ##
============================================
- Coverage     92.93%   92.79%   -0.14%     
- Complexity      545      547       +2     
============================================
  Files            48       48              
  Lines          1825     1818       -7     
  Branches        222      222              
============================================
- Hits           1696     1687       -9     
- Misses           61       63       +2     
  Partials         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov marked this pull request as ready for review August 20, 2024 13:46
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, approved.

@o-kopysov o-kopysov merged commit 8fce5a3 into main Aug 21, 2024
10 checks passed
@o-kopysov o-kopysov deleted the update-version branch August 21, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants