Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Svace issue with ignored check #572

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: Fix Svace issue with ignored check #572

merged 1 commit into from
Aug 14, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Fix for the Svace issue with ignored check for mkdir()

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the fix label Aug 13, 2024
@o-kopysov o-kopysov added this to the v1.6.0 milestone Aug 13, 2024
@o-kopysov o-kopysov self-assigned this Aug 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (57c5e2b) to head (561e048).

Files Patch % Lines
src/main/java/com/lpvs/util/LPVSFileUtil.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #572      +/-   ##
============================================
- Coverage     93.08%   92.93%   -0.16%     
  Complexity      545      545              
============================================
  Files            48       48              
  Lines          1822     1825       +3     
  Branches        221      222       +1     
============================================
  Hits           1696     1696              
- Misses           59       61       +2     
- Partials         67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@o-kopysov o-kopysov merged commit 8b5fb97 into main Aug 14, 2024
10 checks passed
@o-kopysov o-kopysov deleted the html-report branch August 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants