-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show LPVS logo at the app start #559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
============================================
+ Coverage 92.57% 92.64% +0.06%
- Complexity 529 530 +1
============================================
Files 48 48
Lines 1737 1753 +16
Branches 208 208
============================================
+ Hits 1608 1624 +16
Misses 64 64
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I like this variant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting variant. Thanks. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
@tiokim Please take a look at this PR. I would be grateful for your review and feedback. |
Signed-off-by: Oleg Kopysov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👍🏻
Pull Request
Description
The current PR adds the feature to show the LPVS logo at the start of the app. Besides that, it contains the app's version number. I tried to take the number from the POM file but failed to do this at the app start - I was successful in getting the version when all was already loaded, but we need it at the app launching time. So, the version number was hardcoded near the logo.
Type of change
Please delete options that are not relevant.
Testing
Checklist: