Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show LPVS logo at the app start #559

Merged
merged 1 commit into from
Aug 5, 2024
Merged

feat: Show LPVS logo at the app start #559

merged 1 commit into from
Aug 5, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

The current PR adds the feature to show the LPVS logo at the start of the app. Besides that, it contains the app's version number. I tried to take the number from the POM file but failed to do this at the app start - I was successful in getting the version when all was already loaded, but we need it at the app launching time. So, the version number was hardcoded near the logo.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

image

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Aug 1, 2024
@o-kopysov o-kopysov added this to the v1.6.0 milestone Aug 1, 2024
@o-kopysov o-kopysov self-assigned this Aug 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (7d63c2d) to head (ccdc8f8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #559      +/-   ##
============================================
+ Coverage     92.57%   92.64%   +0.06%     
- Complexity      529      530       +1     
============================================
  Files            48       48              
  Lines          1737     1753      +16     
  Branches        208      208              
============================================
+ Hits           1608     1624      +16     
  Misses           64       64              
  Partials         65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-rudyk
Copy link
Collaborator

m-rudyk commented Aug 2, 2024

I like this variant

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting variant. Thanks. Approved.

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@o-kopysov
Copy link
Collaborator Author

@tiokim Please take a look at this PR. I would be grateful for your review and feedback.

Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍🏻

@o-kopysov o-kopysov merged commit 420cc39 into main Aug 5, 2024
10 checks passed
@o-kopysov o-kopysov deleted the add-logo branch August 5, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants