Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check for empty number of files in dir before scan #431

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

m-rudyk
Copy link
Collaborator

@m-rudyk m-rudyk commented Feb 16, 2024

Pull Request

Description

Add check for empty folder before scan for case when files not downloaded.

Fixes #399

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@m-rudyk m-rudyk added the fix label Feb 16, 2024
@m-rudyk m-rudyk self-assigned this Feb 16, 2024
@m-rudyk m-rudyk force-pushed the m.rudyk/fix_empty_commit_interrupt branch from 636bd78 to 52c3965 Compare February 16, 2024 08:59
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c44618e) 90.81% compared to head (52c3965) 90.75%.

Files Patch % Lines
...c/main/java/com/lpvs/service/LPVSQueueService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #431      +/-   ##
============================================
- Coverage     90.81%   90.75%   -0.06%     
  Complexity      489      489              
============================================
  Files            47       47              
  Lines          1731     1731              
  Branches        207      207              
============================================
- Hits           1572     1571       -1     
  Misses           97       97              
- Partials         62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov added this to the v1.4.2 milestone Feb 16, 2024
@o-kopysov o-kopysov marked this pull request as ready for review February 16, 2024 09:11
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit f6fc79e into Samsung:main Feb 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception during analyzing PR with empty commit
4 participants