Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add plugin to build executable JAR #427

Merged
merged 1 commit into from
Feb 11, 2024
Merged

chore: add plugin to build executable JAR #427

merged 1 commit into from
Feb 11, 2024

Conversation

m-rudyk
Copy link
Collaborator

@m-rudyk m-rudyk commented Feb 9, 2024 •
edited
Loading

Pull Request

Description

Add possibility to reuse class from external LPVS through external JAR dependency

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

o-kopysov
o-kopysov reviewed Feb 9, 2024
View reviewed changes
pom.xml Outdated
<dependency>
<groupId>org.springframework.boot.experimental</groupId>
<artifactId>spring-boot-thin-layout</artifactId>
<version>1.0.31.RELEASE</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ver 1.0.30

@m-rudyk m-rudyk force-pushed the m.rudyk/add_plugin_for_exec_jar branch from 1e014fb to 8ab2a7c Compare February 9, 2024 15:14
o-kopysov
o-kopysov approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t-naumenko
t-naumenko approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 8c5830a into Samsung:main Feb 11, 2024
7 checks passed
@o-kopysov o-kopysov added this to the v1.4.2 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-naumenko t-naumenko t-naumenko approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@tiokim tiokim Awaiting requested review from tiokim tiokim is a code owner

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

@tdrozdovsky tdrozdovsky Awaiting requested review from tdrozdovsky tdrozdovsky is a code owner

Assignees

@m-rudyk m-rudyk

Labels
None yet
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@m-rudyk @o-kopysov @t-naumenko