Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing unit-tests for entities and enums #247

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

o-kopysov
Copy link
Collaborator

Signed-off-by: Oleg Kopysov [email protected]

Description

We have to cover more classes by unit tests to improve code coverage.
In this PR, missing entity and enum classes are covered by additional unit tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Oct 14, 2023
@o-kopysov o-kopysov self-assigned this Oct 14, 2023
@o-kopysov o-kopysov changed the title feat: Add missing unit-tests for entities and enums feat: Add missing unit-tests for entities and enums Oct 14, 2023
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tdrozdovsky tdrozdovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit e8a1f34 into Samsung:main Oct 16, 2023
5 checks passed
@o-kopysov o-kopysov deleted the ut-controller branch October 16, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants