Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add unit tests for entity\history classes #244

Merged
merged 2 commits into from
Oct 13, 2023
Merged

feat: Add unit tests for entity\history classes #244

merged 2 commits into from
Oct 13, 2023

Conversation

o-kopysov
Copy link
Collaborator

Description

We have to cover more classes by unit tests to improve code coverage.
In this PR entity\history classes are covered by additional unit tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Oct 12, 2023
@o-kopysov o-kopysov self-assigned this Oct 12, 2023
m-rudyk
m-rudyk reviewed Oct 12, 2023
View reviewed changes
src/test/java/com/lpvs/entity/history/HistoryPageEntityTest.java Outdated
assertFalse(entity1.equals(entity2));
assertFalse(entity2.equals(entity1));
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add empty line

m-rudyk
m-rudyk reviewed Oct 12, 2023
View reviewed changes
src/test/java/com/lpvs/entity/history/LPVSHistoryTest.java Outdated
assertFalse(history1.equals(history2));
assertFalse(history2.equals(history1));
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

m-rudyk
m-rudyk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for increasing coverage. Approved

tiokim
tiokim approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit c3bd273 into Samsung:main Oct 13, 2023
5 checks passed
@o-kopysov o-kopysov deleted the ut-history branch October 13, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-rudyk m-rudyk m-rudyk approved these changes

@tiokim tiokim tiokim approved these changes

@tdrozdovsky tdrozdovsky Awaiting requested review from tdrozdovsky tdrozdovsky is a code owner

@o-konoval o-konoval Awaiting requested review from o-konoval

@v-kerimov v-kerimov Awaiting requested review from v-kerimov

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees

@o-kopysov o-kopysov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@o-kopysov @tiokim @m-rudyk