Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github OAuth feature to backend application #222

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tiokim
Copy link
Member

@tiokim tiokim commented Sep 27, 2023

Description

It is intended to login with Github or Github Enterprise account.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Creating an OAuth app from Github is required. see the official doc.
  2. Place the necessary values to the properties, client-id and client-secret, in docker-compose.yml file.
  3. Build with docker compose build and run the lpvs container with docker compose up
  4. Go to http://localhost:7896/login on the web browser and choose Github.

Test Configuration:

  • Java: v11
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection, approved.

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit c8889fd into Samsung:main Oct 4, 2023
5 checks passed
@tiokim tiokim deleted the github branch October 4, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants