Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add History page. #220

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Add History page. #220

merged 12 commits into from
Oct 4, 2023

Conversation

kyudori
Copy link
Contributor

@kyudori kyudori commented Sep 23, 2023 •
edited
Loading

Description

LPVS Front-End History Page.
History Page provides a history of generated PRs.

  • My Pull Request - History of PR I created
  • My Repo PR - History of PR created in My Repository
  • My Org PR - History of PR created in my organization

Result, Dashboard pages will be uploaded.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

  1. Update environment variables of docker-compose.yml file.
  2. Build the lpvs container : docker compose build
  3. Run containers: docker compose up -d
  4. See the lpvs home page with any browser: http://localhost:7896

For using social login with Naver, Kakao, and Google, fill the necessary information:

  • Update the application.properties located in src/main/resources:
    Enter client-id and client-secret. (Kakao doesn't require a client-secret.)
  • Update the .env file located in frontend:
    Enter your REST_API_KEY.

The values required to implement the login function can be obtained from the link below.
Naver: https://developers.naver.com/products/login/api/api.md
Kakao: https://developers.kakao.com/docs/latest/ko/kakaologin/common
Google: https://cloud.google.com/identity-platform/docs/web/google

history
history_repo

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

kyudori and others added 5 commits September 21, 2023 09:47
@kyudori @quswjdgma83 @Basaeng
Add history front page.
fc48b77 
Signed-off-by: June Saehwan <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@kyudori @quswjdgma83 @hwan5180
Add History backend logic.
264558f 
Signed-off-by: jongmin Lee <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Correcting front-end errors.
7a4f64e 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@Basaeng @kyudori
@quswjdgma83 @hwan5180
Correcting back-end errors
f325942 
Signed-off-by: jongmin Lee <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@Basaeng @kyudori
@quswjdgma83 @hwan5180
Fix history page error
a040753 
Signed-off-by: jongmin Lee <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@kyudori

This comment has been minimized.

Sign in to view
@o-kopysov o-kopysov requested a review from m-rudyk September 23, 2023 07:34
@kyudori kyudori marked this pull request as draft September 23, 2023 07:45
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Update Test files
5fe5ded 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@kyudori kyudori marked this pull request as ready for review September 23, 2023 14:14
@tiokim tiokim closed this Sep 24, 2023
@tiokim tiokim reopened this Sep 24, 2023
@tiokim
Copy link
Member

tiokim commented Sep 24, 2023

[License Pre-Validation Service] No license issue detected

Detected licenses:

File: src/test/java/com/lpvs/util/WebHookUtilTest.java
License(s): MIT (permitted)
Component: LPVS (test/java/com/lpvs/util/WebHookUtilTest.java)
Matched Lines: 25-120
Snippet Match: 79%

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Edit indentation in the test file
066fb0e 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@tiokim
Copy link
Member

tiokim commented Sep 24, 2023

[License Pre-Validation Service] No license issue detected

Detected licenses:

File: src/test/java/com/lpvs/util/WebHookUtilTest.java
License(s): MIT (permitted)
Component: LPVS (test/java/com/lpvs/util/WebHookUtilTest.java)
Matched Lines: 25-120
Snippet Match: 79%

tiokim
tiokim reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please take a look at my review comments

frontend/src/pages/Home.jsx Outdated Show resolved Hide resolved
src/main/java/com/lpvs/util/LPVSWebhookUtil.java Outdated Show resolved Hide resolved
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Edit Home.jsx indentation
67858fb 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@tiokim tiokim mentioned this pull request Sep 27, 2023
Closed
m-rudyk
m-rudyk approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Small remarks

Basaeng and others added 2 commits October 1, 2023 22:57
@Basaeng @kyudori
@quswjdgma83 @hwan5180
Fix HistoryPage Errors
7943e76 
Signed-off-by: jongmin Lee <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@kyudori
Merge pull request #1 from kyudori/history_page_fix
d02a7c2 
Edit sender, head, base
@o-kopysov
Copy link
Collaborator

@Basaeng Please check build errors and fix them.

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Update Test File, db_dump, header.
47a74d7 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@kyudori
Copy link
Contributor Author

kyudori commented Oct 3, 2023 •
edited
Loading

@Basaeng Please check build errors and fix them.

@o-kopysov
With the addition of pull_request_base and pull_request_head to the pull_requests table, errors occurred in the test code.
Now resolved these errors by modifying the test code.

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Update header.
a5b3195 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
tiokim
tiokim approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit c7ee6e8 into Samsung:main Oct 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o-kopysov o-kopysov o-kopysov left review comments

@m-rudyk m-rudyk m-rudyk approved these changes

@tiokim tiokim tiokim approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyudori @tiokim @o-kopysov @m-rudyk @Basaeng