Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put frontend assets to the lpvs container #218

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

tiokim
Copy link
Member

@tiokim tiokim commented Sep 20, 2023

Description

This PR is intended to provide frontend and backend services in the lpvs container.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  1. Update environment variables of docker-compose.yml file.
  2. Build the lpvs container : docker compose build
  3. Run containers: docker compose up -d
  4. See the lpvs home page with any browser: http://localhost:7896

Test Configuration:

  • Java: v11
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tiokim
Copy link
Member Author

tiokim commented Sep 20, 2023

@kyudori Can you check if this PR works well?

@kyudori
Copy link
Contributor

kyudori commented Sep 20, 2023

@kyudori Can you check if this PR works well?

@tiokim Yes.
I checked frontend page working successfully (in docker container) :

  1. Google social login.
  2. Modifying user information on the user/info page.
  3. Logout.

All three processes are working successfully.

Docker

@kyudori
Copy link
Contributor

kyudori commented Sep 20, 2023

@kyudori Can you check if this PR works well?

@tiokim However, when refreshing the user/info page with an F5, JSON-format data is displayed instead of the front-end page.
image

LPVS backend and frontend have the same interface, /user/info,
so the frontend interface is changed to /user/setting.
@tiokim
Copy link
Member Author

tiokim commented Sep 20, 2023

@kyudori Can you check if this PR works well?

@tiokim However, when refreshing the user/info page with an F5, JSON-format data is displayed instead of the front-end page. image

@kyudori Please verify it again.

@kyudori
Copy link
Contributor

kyudori commented Sep 20, 2023

@kyudori Please verify it again.

@tiokim Front page is displayed successfully even after refreshing F5.
(JSON data is no longer visible.)

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Approved from my side, but required testing by someone else.

Copy link
Collaborator

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tiokim tiokim merged commit 4df6c93 into Samsung:main Sep 20, 2023
5 checks passed
@tiokim tiokim deleted the frontendContainer branch October 4, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants