Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling code during login check #216

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add error handling code during login check #216

merged 1 commit into from
Sep 15, 2023

Conversation

tiokim
Copy link
Member

@tiokim tiokim commented Sep 15, 2023

Description

An error happens when a request to add the new member to db is called twice in a row due to StrictMode.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Run frontend server with npm start at frontend folder.
  2. Open Chrome browser with DevTools and Go to http://localhost:3000.
  3. See the network requests,login/check, from DevTools.

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tiokim
Add error handling code during login check
0a03f4f 
An error happens when a request to add the new member to db
is called twice in a row due to StrictMode.

Signed-off-by: Taewan Kim <[email protected]>
@tiokim tiokim added the bug Something isn't working label Sep 15, 2023
@tiokim tiokim requested a review from m-rudyk September 15, 2023 08:17
o-kopysov
o-kopysov approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-rudyk
m-rudyk approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection, approved.

@o-kopysov o-kopysov merged commit f902dbc into Samsung:main Sep 15, 2023
5 checks passed
@tiokim tiokim deleted the front_bug branch May 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-rudyk m-rudyk m-rudyk approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiokim @o-kopysov @m-rudyk