Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend home page #204

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Add frontend home page #204

merged 4 commits into from
Sep 4, 2023

Conversation

kyudori
Copy link
Contributor

@kyudori kyudori commented Sep 2, 2023 •
edited
Loading

Description

LPVS Front-End Home Page.
Login, User, History, and Dashboard pages will be uploaded.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

$npm install
$npm start
Go to http://localhost:3000 with Chrome.
image

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kyudori @quswjdgma83
@hwan5180 @Basaeng
frontend home page
d3788e2 
Signed-off-by: Hankyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Hwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Clean up unnecessary code.
3d7afff 
Signed-off-by: Hankyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Hwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
o-kopysov
o-kopysov approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-rudyk
m-rudyk reviewed Sep 3, 2023
View reviewed changes
frontend/.env Outdated Show resolved Hide resolved
@o-kopysov
Copy link
Collaborator

Also I recommend to add file headers into the files with source code.

@tiokim
Copy link
Member

tiokim commented Sep 3, 2023

Also I recommend to add file headers into the files with source code.

Do you mean copyright/license header?

@o-kopysov
Copy link
Collaborator

Do you mean copyright/license header?

Yes, exactly.

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Add file headers and empty line.
f74ad47 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Hwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
o-kopysov
o-kopysov approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiokim
tiokim requested changes Sep 4, 2023
View reviewed changes
frontend/public/index.html Outdated Show resolved Hide resolved
@kyudori
Add index.html annotation
264e85e 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Hwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
tiokim
tiokim approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiokim tiokim merged commit b560674 into Samsung:main Sep 4, 2023
5 checks passed
@kyudori kyudori changed the title frontend home page Add frontend home page Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-rudyk m-rudyk m-rudyk left review comments

@o-kopysov o-kopysov o-kopysov approved these changes

@tiokim tiokim tiokim approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

@tdrozdovsky tdrozdovsky Awaiting requested review from tdrozdovsky tdrozdovsky is a code owner

@o-konoval o-konoval Awaiting requested review from o-konoval

@v-kerimov v-kerimov Awaiting requested review from v-kerimov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyudori @o-kopysov @tiokim @m-rudyk