Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] refactor of transcribe.py[DISCUSS] #1096

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BBC-Esq
Copy link
Contributor

@BBC-Esq BBC-Esq commented Oct 27, 2024

This is an initial DRAFT to float/discuss the idea of using a centralized configuration class. It reduces the current code base of transcribe.py by approximately 12,000 character while, in theory, achieving the same functionality. I'm referring to ~12,000 character reduction in code logic, not comments or docstrings. Consolidating some of those as well should further reduce the code base.

Again, a jumping off point for a discussion. Thanks!

@BBC-Esq BBC-Esq changed the title [DRAFT] refactor of transcribe.py [DRAFT] refactor of transcribe.py[DISCUSS] Oct 27, 2024
@MahmoudAshraf97
Copy link
Collaborator

I suggest we turn this into an issue or a discussion where we can share ideas, this is much more understandable than a PR

@BBC-Esq
Copy link
Contributor Author

BBC-Esq commented Oct 27, 2024

okay, not sure how to do that...Can you convert it or...

@MahmoudAshraf97
Copy link
Collaborator

Close this and open an issue or a discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants