-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New PR for Faster Whisper: Batching Support, Speed Boosts, and Qualit…
…y Enhancements (#856) Batching Support, Speed Boosts, and Quality Enhancements --------- Co-authored-by: Hargun Mujral <[email protected]> Co-authored-by: MahmoudAshraf97 <[email protected]>
- Loading branch information
1 parent
fbcf58b
commit eb83902
Showing
13 changed files
with
1,693 additions
and
419 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
include faster_whisper/assets/silero_vad.onnx | ||
include requirements.txt | ||
include requirements.conversion.txt | ||
include faster_whisper/assets/pyannote_vad_model.bin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
eb83902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Letting you know that this commit broke my app deps. I have ffmpeg 7.0.1 built from source at /usr/bin/ffmpeg which I use for other app services. Somehow faster-whisper gets stuck in a loop trying to load ffmpeg 6.
I belive this has to do with removing
av
from deps and using torchaudio directly, as torchaudio is not compatible with ffmpeg 7 yet and probably tries to use the ffmpeg binary it finds at /usr/bin.Reverting to commit c22db51 works fine with ffmpeg 7 around.
eb83902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bullshit update, you split torch dependencies all over the place which does not bring any advantage but gigabytes of package dependency. Using Numpy is a more versatile and reusable way to put the library in a good place. This PR made faster whisper in a terrible state.