Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVProgressHUD should support single window apps adopting SceneDelegate #978

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slizeray
Copy link

The window property on the app delegate is nil when using a SceneDelegate

…property on the application delegate. It make the lib compatible with apps which adopt the new Scene protocol
Copy link

@tanis2000 tanis2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanis2000
Copy link

It would be nice to have this merged into a new release

@artem-alexandrov
Copy link

Aaaaaand? :) Will it be merged soon?

@binsnoel
Copy link

binsnoel commented Oct 5, 2020

when will this be merged? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants