New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display progress HUD in a specific view #753
base: master
Are you sure you want to change the base?
Conversation
I got a problem with these addition: It is only for one specific method (progress). You forgot that if something like this is added it should go also with images etc. (showSuccess, ...). |
31e6133
to
2490ffc
Compare
@honkmaster Good point, added the |
@honkmaster do you still have an interest in this feature? |
23ace16
to
2490ffc
Compare
@honkmaster @toohotz Bumping this. We could definitely use this functionality. Anything keeping it from being mergeable? Happy to help out if needed. |
+1 on getting this added. However, does the dispatchOnce functionality mess anything up in this use case if the HUD is to be added to multiple different views? |
@honkmaster added also some nullability specifiers for use in Swift to prevent the explicitly unwrapped optionals from causing issues with improper usage. |
Now this PR ist mutliple things at once. 1) Show in specific view 2) Nullability. However, I am working on the HUD today and will see what I can do. |
@honkmaster Being able to add the progress spinner to a specific view and multiple views at once would be great. :) |
@honkmaster Noticed that the nullability specifiers were added in from another commit. Have the changes resolved on my end though I wanted to understand better why for the completion block of |
@honkmaster Can we get this merged in? |
@honkmaster any updates on this PR? Seems like others are interested in having this feature. |
For anyone that just wants an indefinite spinner, you can just use |
|
@toohotz @brandons As said earlier, if you would split your commits and bugfixes to single pull requests I could merge them quite easily. However, at the moment this PR does fix / add multiple things at once. Merging would clutter the timeline and adds additional workload for me ... Thus I keep away from this at the moment. |
71610bc
to
d9c6f8a
Compare
…toohotz/hudSpecificView # Conflicts: # SVProgressHUD/SVProgressHUD.h
d9c6f8a
to
b0ec7ce
Compare
@honkmaster agreed, realized that much after my commit for the bugfix that it was fixed anyway so I removed the commit for the nullability and updated my functions as well as documented the README also. |
Sorry, but... will this feature be available? I mean attaching to a specific view, thus blocking this view. I used |
@NikKovIos I'm still waiting on @honkmaster to review this PR. @honkmaster any updates? |
I am working today on the HUD. During this I was browsing the commit history and thinking about @NikKovIos comment. He is correct, the |
@honkmaster agreed that is the purpose of the |
I realized that in my own project I wanted the flexibility to add the hud to a specific view and not to the overall view in general all the time. Wanted to get your thoughts on if you would like this option as well in the master branch for others that would like this as well.