Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow customization to the shared view #1008

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

javisanesp
Copy link

Hello there.

I am making this PR because on our project https://github.com/meganz/iOS our designers request us to add some customization to this HUD and to add it some depth from the background views AKA shadow 😄 . I do not know if this could be done with other methods, but just in case you find it useful.

I did not added properties for this layer values because I think they are not necessary.

I wrote the defaults values that appear on the Apple documentation on the comments of the methods in the header file.

In case you are interested on this PR, please tell me if I need to add or change anything so you can merge it, if not please feel free to close the PR.

Thank you for your time.

Cheers!

Example for the shadow

@honkmaster
Copy link
Member

This PR is missing updates to the Readme. Please add.

@javisanesp
Copy link
Author

Sorry about that, forgot to add them. All good?

@ibtikarat
Copy link

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[SVProgressHUD setShadowColor:]: unrecognized selector sent to class 0x1092c3618'
I have crashed

@javisanesp
Copy link
Author

Hello @ibtikarat.
Can you explain how did you crash? Are you pointing to the branch meganz:shadow_customization to use the method setShadowColor?

@javisanesp
Copy link
Author

Sorry to bother again @honkmaster, but... Am I missing something? Can I help you?

@reinaldosmoraes
Copy link

@javisanesp it looks great and I'd like to use it. @honkmaster Is this PR ready to be merged? If so, can you merge it, please?

@jnavarrom
Copy link
Contributor

Hi @honkmaster

Please, would you mind reviewing this PR when you have time?
Any more changes we need to make on our end?

Thank you

@arielelkin
Copy link

Hello @honkmaster. We're also interested in this feature being merged. Please let us know if we can help 😀

@jnavarrom
Copy link
Contributor

@juliensaad can you take a look at this PR when you have time?

Thanks!

@javisanesp
Copy link
Author

@MuteQ sorry to bother, I saw that you merged a PR recently. Could you please take a look to this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants