Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Incapsulate validators #452

Merged
merged 5 commits into from
Nov 28, 2024
Merged

♻️ Incapsulate validators #452

merged 5 commits into from
Nov 28, 2024

Conversation

AntPolkanov
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

#448

  1. What was changed?
  • made validators internal sealed
  • removed transitive dependencies
  • some global using files were called Usings.cs, some GlobalUsings.cs and Architecture.Tests had both. Renamed to GlobalUsings.cs.
  • used Aspire .NET 9 version instead of RC
  1. Did you do pair or mob programming?
    No

AntPolkanov
AntPolkanov commented Nov 27, 2024
View reviewed changes
Copy link
Member Author

@AntPolkanov AntPolkanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge PR while we are running the Clean Architecture workshop.

danielmackay
danielmackay approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmackay danielmackay merged commit 9262725 into main Nov 28, 2024
2 checks passed
@danielmackay danielmackay deleted the improvements branch November 28, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmackay danielmackay danielmackay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntPolkanov @danielmackay