Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷‍♂️ 306 move seed data and migrations out of api #309

Merged
merged 8 commits into from
May 21, 2024

Conversation

danielmackay
Copy link
Member

@danielmackay danielmackay commented May 20, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ #294

  1. What was changed?

✏️ Previously DB creation and data seeding was done in Program.cs in Development mode. There is risk that this might be run on PROD which isn't great.P

Migrated DB migrations and seeding to a new project under Tools\Database. This project is then called by up.ps1 to handle creation of SQL Server, DB, and Seed data all in one command.

  1. Did you do pair or mob programming?

✏️ Yes with @william-liebenberg

Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May be worth adding a note in the docs about the tools\Database project.

@danielmackay danielmackay merged commit 91d1b69 into main May 21, 2024
2 checks passed
@danielmackay danielmackay deleted the 306--move-seed-data-and-migrations-out-of-api branch May 21, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Move Seed Data and Migrations Out of API
2 participants