Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Superhero Domain and DDD Patterns #277

Merged
merged 22 commits into from
Apr 15, 2024
Merged

✨ Add Superhero Domain and DDD Patterns #277

merged 22 commits into from
Apr 15, 2024

Conversation

danielmackay
Copy link
Member

@danielmackay danielmackay commented Apr 5, 2024 •
edited by christoment
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️
#283
#261

  1. What was changed?

✏️
Add Superhero Domain and DDD Patterns

  1. Did you do pair or mob programming?

✏️
PR is worked and reviewed together by @danielmackay @wicksipedia @matt-goldman @christoment

@danielmackay danielmackay linked an issue Apr 5, 2024 that may be closed by this pull request
✨ DDD - Add Aggregate Root to Domain #261
Closed
@danielmackay danielmackay changed the title Add Superhero Domain and DDD Patterns ✨ Add Superhero Domain and DDD Patterns Apr 5, 2024
Hona
Hona previously requested changes Apr 8, 2024
View reviewed changes
src/Domain/Common/Base/AggregateRoot.cs Outdated Show resolved Hide resolved
src/Domain/Common/Base/Entity.cs Show resolved Hide resolved
src/Domain/Heroes/StrengthUpdatedEvent.cs Outdated Show resolved Hide resolved
christoment
christoment approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@christoment christoment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we will have to action the TODO ASAP though

@wicksipedia wicksipedia force-pushed the 261--ddd---add-aggregate-root-to-domain branch from 9effcf3 to 1220d20 Compare April 15, 2024 00:59
@wicksipedia wicksipedia mentioned this pull request Apr 15, 2024
Closed
@wicksipedia wicksipedia mentioned this pull request Apr 15, 2024
Open
@danielmackay danielmackay requested review from Hona and removed request for Hona April 15, 2024 02:12
@wicksipedia wicksipedia dismissed Hona’s stale review April 15, 2024 02:13

other people have reviewed it

@danielmackay danielmackay merged commit 23fa27e into main Apr 15, 2024
2 checks passed
@danielmackay danielmackay deleted the 261--ddd---add-aggregate-root-to-domain branch April 15, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoment christoment christoment approved these changes

@Hona Hona Awaiting requested review from Hona

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ DDD - Add Aggregate Root to Domain
3 participants
@danielmackay @Hona @christoment