Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update ADR template.md to use SSW placeholders #190

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

jernejk
Copy link
Member

@jernejk jernejk commented Oct 27, 2023

Change based on SSW rule: https://www.ssw.com.au/rules/placeholder-for-replaceable-text/

UPDATE: I tested the template against log4brains adr new and these changes didn't break any of the log4brains features.

@danielmackay
Copy link
Member

@jernejk - can you update your fork from the upstream repo and try the build again?

@jernejk
Copy link
Member Author

jernejk commented Dec 12, 2023

Updated, let me know if it worked. :)

@danielmackay danielmackay self-requested a review December 12, 2023 08:44
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmackay danielmackay changed the title Update ADR template.md to use SSW placeholders 📝 Update ADR template.md to use SSW placeholders Dec 12, 2023
@danielmackay danielmackay merged commit e3b2af4 into SSWConsulting:main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants