Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Changed startup project in SLN file #147

Closed
wants to merge 3 commits into from
Closed

♻️ Changed startup project in SLN file #147

wants to merge 3 commits into from

Conversation

jernejk
Copy link
Member

@jernejk jernejk commented Jul 24, 2023

When creating a new project, the default was Domain, but this change will make WebAPI as the startup project.

image
Figure: Opened the project for the first time after applying the fix.

@danielmackay
Copy link
Member

@jernejk - can you fix the build error?

@jernejk
Copy link
Member Author

jernejk commented Aug 1, 2023

Hi @danielmackay, the build error I have is about unable to create a test report because it does not have access to a resource.

It's probably because it's a fork and my fork doesn't have access to the necessary resources.
image

@danielmackay
Copy link
Member

@jernejk - can you try fixing the error but adding the following permissions to the workflow?

permissions:
  id-token: write
  contents: read
  checks: write

As per: dorny/test-reporter#149 (comment)

@wicksipedia
Copy link
Member

wicksipedia commented Aug 9, 2023

its most probably because he's running from a fork - pull_request triggers only have read only access to the target repo.

If you want to continue to use the test-reporter action, you need to add another action that listens for the build/test to complete, download the trx artifacts then add them to the pr.... similar to https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

@jernejk jernejk closed this by deleting the head repository Oct 27, 2023
@danielmackay
Copy link
Member

@jernejk - why was this closed? This is something that we'd still like to fix (once we sort the forking issue).

@jernejk
Copy link
Member Author

jernejk commented Oct 28, 2023

I committed the code to main of my fork as I thought it will be an simple PR but since I have no ability to fix the build and wanted to create a new PR, I just deleted the fork and start over.

I might recreate the PR once we figure out how I can contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants