Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-2503 Fix layout in place where there is mixed content #547

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mutaben
Copy link
Collaborator

@mutaben mutaben commented Mar 21, 2025

Description

Some places have mixed content, so the square and 16:9 images were mixed because of the previous logic.

Changes Made

  • Since there is no consistency on how this is happening and some data driven discriminator, I had to introduce a boolean flag to implement this

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the bug Issue to be fix (issue and PR) - release notes section label Mar 21, 2025
@mutaben mutaben requested review from defagos and waliid March 21, 2025 08:41
@mutaben mutaben enabled auto-merge March 28, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants