Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAYRTS-5591 Update SRG libraries #503

Merged
merged 3 commits into from
Jul 23, 2024
Merged

PLAYRTS-5591 Update SRG libraries #503

merged 3 commits into from
Jul 23, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jul 18, 2024 •
edited by pyby
Loading

Description

SRGAnalytics have been update in order to have signed language and audio description analytics.
SRGDataProvider have been updated to provide journalistic blocking reason.

This PR updates those libraries to have both.

Changes Made

Update both libraries through SPM.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added improvement Feature or update (issue and PR) - release notes section maintenance Code maintenance (issue and PR) - release notes section labels Jul 18, 2024
@mutaben mutaben requested a review from pyby July 18, 2024 09:14
@pyby
Copy link
Member

pyby commented Jul 22, 2024

Some manual test did and explained in the private SRGSSR ticket: https://srgssr-ch.atlassian.net/browse/PLAYRTS-5591

@pyby pyby removed the maintenance Code maintenance (issue and PR) - release notes section label Jul 22, 2024
@pyby pyby changed the title PLAYRTS-5591 - Update SRG libraries PLAYRTS-5591 Update SRG libraries Jul 22, 2024
@mutaben mutaben added this pull request to the merge queue Jul 23, 2024
Merged via the queue into develop with commit 13ea6db Jul 23, 2024
1 check passed
@mutaben mutaben deleted the feature/PLAYRTS-5591-analytics-update branch July 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyby pyby pyby approved these changes

Assignees
No one assigned
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutaben @pyby