Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5562 Open player if media highlight section as only one media #496

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Jun 17, 2024

Description

As a user
I want to play the media highlight content with less tap/click if only one editorialised media in
so that I don’t ask myself with this highlight detail page exists with only one content.

Changes Made

  • A section could have an highlighted item now.
  • If this section as only 1 item, it's the highlighted.
  • PageViewController displays the media player page if the highlighted is a media.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the improvement Feature or update (issue and PR) label Jun 17, 2024
@pyby pyby requested review from mutaben and amtins June 17, 2024 18:08
Do not force to player directly
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5562-open-media-highlight June 17, 2024 18:30 Inactive
@pyby pyby removed the request for review from amtins June 18, 2024 13:01
@pyby pyby changed the title PLAYRTS-5562 Open player if media highlight as only one media PLAYRTS-5562 Open player if highlight as only one media Jun 18, 2024
@pyby pyby changed the title PLAYRTS-5562 Open player if highlight as only one media PLAYRTS-5562 Open player if media highlight section as only one media Jun 18, 2024
@pyby pyby added this pull request to the merge queue Jun 19, 2024
Merged via the queue into develop with commit 5e70683 Jun 19, 2024
2 checks passed
@pyby pyby deleted the feature/PLAYRTS-5562-open-media-highlight branch June 19, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants