Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5566 SwiftFormat and trim trailing whitespaces #495

Merged
merged 13 commits into from
Jun 17, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Jun 16, 2024

Description

As a developer
I want to have same default Xcode configuration for all developers and better swift format
so that new PRs don’t have whitespace issues and different swift styles.

Important

For developers:

  • Enable Xcode “While Editing: Including whitespace-only lines” option when this PR is merged.
  • Run brew install swiftformat.

Testing manually the Xcode UI menu "Structure / Re-Indent", SwiftFormat tools has been tested, and it looks interesting to have it for a better swift code style.

Following #483, add swiftformat lint in build phases to help developers to check formatting during debug compilation.

Changes Made

  • Add swiftformat in make check-quality and make fix-quality.
  • Add swiftformat linter in build phases.
  • Update all Swift files with swiftformat rules and Swift 5.10 updates.
  • Improve few Swift codes to be conform to swiftformat rules.
  • Update all Objective-C files with the Xcode menu "Structure / Re-Indent".

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the dev tool Dev tool improvement or update (issue and PR) label Jun 16, 2024
@pyby pyby requested a review from mutaben June 16, 2024 22:59
@pyby pyby changed the title PLAYRTS-5566 Swift Format and trim trailing whitespace PLAYRTS-5566 SwiftFormat and trim trailing whitespace Jun 16, 2024
@pyby pyby changed the title PLAYRTS-5566 SwiftFormat and trim trailing whitespace PLAYRTS-5566 SwiftFormat and trim trailing whitespaces Jun 16, 2024
@pyby pyby marked this pull request as ready for review June 16, 2024 23:35
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5566-swift-format June 16, 2024 23:36 Inactive
@rts-devops rts-devops had a problem deploying to playsrg-ios-nightly+PLAYRTS-5566-swift-format June 16, 2024 23:37 Error
@rts-devops rts-devops had a problem deploying to playsrg-ios-nightly+PLAYRTS-5566-swift-format June 17, 2024 00:18 Error
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5566-swift-format June 17, 2024 08:31 Inactive
Copy link
Contributor

@mutaben mutaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@mutaben mutaben added this pull request to the merge queue Jun 17, 2024
@mutaben mutaben removed this pull request from the merge queue due to a manual request Jun 17, 2024
@pyby pyby added this pull request to the merge queue Jun 17, 2024
Merged via the queue into develop with commit e224b31 Jun 17, 2024
3 checks passed
@pyby pyby deleted the feature/PLAYRTS-5566-swift-format branch June 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev tool Dev tool improvement or update (issue and PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants