Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAYRTS-5533 Always enable blur on bar to avoid UI glitches #491

Merged
merged 2 commits into from
Jun 10, 2024
Merged

PLAYRTS-5533 Always enable blur on bar to avoid UI glitches #491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b97b191
PLAYRTS-5533 Always enable blur
mutaben Jun 10, 2024
8b2fc2b
PLAYRTS-5533 Remove useless line
mutaben Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Application/Sources/UI/Controllers/PageContainerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ class PageContainerViewController: UIViewController {

private func configureBarView() {
let blurView = UIVisualEffectView.play_blurView
blurView.alpha = 0.0
self.blurView = blurView

let barView = TMBarView<TMHorizontalBarLayout, TMTabItemBarButton, TMLineBarIndicator>()
Expand Down Expand Up @@ -169,12 +168,6 @@ extension PageContainerViewController: ScrollableContentContainer {
var play_scrollableChildViewController: UIViewController? {
tabContainerViewController.currentViewController
}

func play_contentOffsetDidChange(inScrollableView scrollView: UIScrollView) {
let adjustedOffset = scrollView.contentOffset.y + scrollView.adjustedContentInset.top
tabBarTopConstraint?.constant = max(-adjustedOffset, 0.0)
blurView?.alpha = max(0.0, min(1.0, adjustedOffset / LayoutBlurActivationDistance))
}
}

extension PageContainerViewController: SRGAnalyticsContainerViewTracking {
Expand Down