Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move # section to end of AZ list (PLAYRTS-5499) #455

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 6, 2024

Motivation and Context

It looked like a mistake if the navigation starts with #0-9 in the "A to Z" view. Also if a user navigates with a screen reader (like VoiceOver), it's easier to understand at the end of the navigation.

The show list should start with “A” section. And “#“ should be at the end of the list.

Description

  • Move "#" section to the end of the AZ list (in Videos and Audios).

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added the bug Issue to be fix (issue and PR) - release notes section label Apr 6, 2024
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+a-z-sorting April 6, 2024 16:01 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+a-z-sorting April 6, 2024 16:02 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+a-z-sorting April 6, 2024 18:19 Inactive
@pyby pyby added this pull request to the merge queue Apr 16, 2024
Merged via the queue into develop with commit b15bb4c Apr 16, 2024
3 checks passed
@pyby pyby deleted the feature/a-z-sorting branch April 16, 2024 15:55
@pyby pyby added improvement Feature or update (issue and PR) - release notes section and removed bug Issue to be fix (issue and PR) - release notes section labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants