-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
891 add dsl for pillarboxcastplayer #894
base: main
Are you sure you want to change the base?
Conversation
Code Coverage
Files
|
fbfe0b3
to
77d4268
Compare
context: Context? = null, | ||
mediaItemConverter: MediaItemConverter = DefaultMediaItemConverter(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not remove all default values?
* | ||
* @param Builder The type of [PillarboxCastPlayerBuilder] that this factory creates. | ||
*/ | ||
interface CastPlayerConfig<Builder : PillarboxCastPlayerBuilder> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use PlayerConfig<PillarboxCastPlayerBuilder>
?
@@ -15,8 +15,7 @@ The main goal of this module is to be able to connect to a SRG SSR receiver with | |||
## Getting started | |||
|
|||
```kotlin | |||
val castContext = context.getCastContext() | |||
val player = PillarboxCastPlayer(castContext = castContext, mediaItemConverter = SRGMediaItemConverter()) | |||
val player = PillarboxCastPlayer(context) // ch.srgssr.pillarbox.core.business.cast.PillarboxCastPlayer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the comment necessary, since we are in pillarbox-core-business-cast
?
val player = PillarboxCastPlayer(context) // ch.srgssr.pillarbox.core.business.cast.PillarboxCastPlayer | |
val player = PillarboxCastPlayer(context) |
Pull request
Description
Introduce same dsl pattern as it has been done with
PillarboxExoPlayer
that can configure each aspect of aPillarboxCastPlayer
.Samples
Changes made
Checklist